[Marble-devel] Review Request: Gps Speed render plugin

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102571/#review6413
-----------------------------------------------------------

Ship it!


I think "gpsinfo" would be a better name than speed.
In the future we could extend our position tracking interface to allow plugins to provide information about satellite states an similar where applicable. This information is quite useful to the user if the initial fix takes long to see what's going on. I often find myself open mappero (N900) in that case.
Minor issues below.



src/plugins/render/speed/Speed.h
<http://git.reviewboard.kde.org/r/102571/#comment5701>

    Can this be private?



src/plugins/render/speed/Speed.cpp
<http://git.reviewboard.kde.org/r/102571/#comment5700>

    For safety (avoiding memory leaks) I'd guard this method in a if ( !isInitialized ) {}



src/plugins/render/speed/Speed.cpp
<http://git.reviewboard.kde.org/r/102571/#comment5702>

    !m_marbleWidget is assured above already



src/plugins/render/speed/Speed.cpp
<http://git.reviewboard.kde.org/r/102571/#comment5703>

    It's mph or mi/h, mph seems to be more common. 



src/plugins/render/speed/Speed.cpp
<http://git.reviewboard.kde.org/r/102571/#comment5704>

    Missing a unit here (degree). Ideally I'd like to see also a graphical representation, probably some kind of compass. Can be done in master after committing.


- Dennis


On Sept. 10, 2011, 7:39 p.m., Thibaut Gridel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102571/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2011, 7:39 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Summary
> -------
> 
> Provides a small box with speed, direction, altitude and precision.
> 
> Useful while checking speed limits...
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/CMakeLists.txt 548b282 
>   src/plugins/render/speed/CMakeLists.txt PRE-CREATION 
>   src/plugins/render/speed/Speed.h PRE-CREATION 
>   src/plugins/render/speed/Speed.cpp PRE-CREATION 
>   src/plugins/render/speed/SpeedPlugin.ui PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102571/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Speed Plugin
>   http://git.reviewboard.kde.org/r/102571/s/253/
> 
> 
> Thanks,
> 
> Thibaut
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20110911/81d7c5e8/attachment.html>