[Marble-devel] Review Request: GeoDataLineString: ensure proper private handling

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102342/#review6389
-----------------------------------------------------------


This review has been submitted with commit 8b13cc370d1024a06393803e51c6b216d8b60075 by Thibaut Gridel to branch master.

- Commit


On Aug. 16, 2011, 6:19 p.m., Thibaut Gridel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102342/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2011, 6:19 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Summary
> -------
> 
> Ensure m_rangeCorrected is deep copied during private copy while detaching.
>     
> This avoids dangling pointers if both detached privates need to update that vector of pointers.
>     
> Thanks: Guillaume Martres for the test cases
> 
> 
> Diffs
> -----
> 
>   src/lib/geodata/data/GeoDataGeometry_p.h 4bed8b6 
>   src/lib/geodata/data/GeoDataLineString_p.h 4e87780 
>   tests/TestGeoDataGeometry.cpp dca91d1 
> 
> Diff: http://git.reviewboard.kde.org/r/102342/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thibaut
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20110910/7e8ff19b/attachment.html>