[Marble-devel] Review Request: Adjustable route overlay color and transparency

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102540/#review6385
-----------------------------------------------------------


I like this feature in general. 
But on one hand there's a bug:

*If I press "Cancel" in the QColorDialog then the color chosen becomes "black". In that case the prior color should be preserved. 

And on the other hand I wonder whether it's done in the right place: It seems that there can be only one route that can be changed in terms of colors. So there is only a single color that can be modified. Also changing the color of the route is something that probably isn't done that often. 

So in order to avoid clutter in the RMB menu, could we move this feature into the plugin settings dialog? Have a look at the following plugins and their configuration dialogs (under Settings->Plugin page):
* Grid  
* Position Marker
* Earthquake
All of them are doing the color setting there. I think it's the appropriate place given the likeliness that the user will have an issue with the color and given the expected amount of times that he will change it. Also you can have a look at the code in those places how the color settings are saved :-)  

Florian: Welcome to the Marble Team! - Great to have you on board - I hope you don't feel discouraged by my comments :-)


- Torsten


On Sept. 6, 2011, 1:50 p.m., Florian Eßer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102540/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2011, 1:50 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Summary
> -------
> 
> The patch from http://mail.kde.org/pipermail/marble-bugs/2011-September/001532.html
> 
> ==============
> 
> Hi,
> I had the same problem myself recently.
> 
> So here's a patch that adds an option "Adjust track color" in the
> track's context menu just below "Export route".
> 
> Todo / Possible enhancements:
> * make all the different route types (e.g. deviated from route)
>   configurable, not just the standard one. Right now, only the alpha
>   values get adjusted for all track types/colors.
> * save/load to config file
> ** and then: button to restore the nice marble defaults if you have
>    experimented to much ;-)
> 
> Greetings
> Florian
> 
> On 28.08.2011 09:48, Robin Seidel wrote:
> > hi, thanks for the great marble!!! I have one wish: could you allow 
> > to adjust the transparency of the route overlay, so one can see the 
> > track beneath, this would be especially helpful for walking routes, 
> > where one may not want to take the smallest paths. Once the route is
> >  found one can currently not easily see what's beneath.
> > 
> > best regards
> > 
> > robin
> 
> 
> Diffs
> -----
> 
>   src/lib/routing/RoutingLayer.h 8610f18 
>   src/lib/routing/RoutingLayer.cpp 3c8adfa 
> 
> Diff: http://git.reviewboard.kde.org/r/102540/diff
> 
> 
> Testing
> -------
> 
> worksforme
> 
> 
> Thanks,
> 
> Florian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20110910/9a3d80aa/attachment.html>