[Marble-devel] Review Request: Plasma Runner which starts Marble for entered lonlat coordinates

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102849/
-----------------------------------------------------------

(Updated Oct. 31, 2011, 9:36 a.m.)


Review request for Marble.


Changes
-------

Updated patch:
* removed TODOs for GeoDataCoordinates::fromString(...), now that https://git.reviewboard.kde.org/r/103000/ is up :)
* made coordinates string passed as parameter to Marble more dense


Description
-------

Initial version of a Plasma Runner which uses Marble. So far can do:
* detect lonlat coordinates and start a new Marble instance showing that coordinates with OSM
* detect Marble bookmarks containing the search string in name or description (unless CDATA)
  and start a new Marble instance showing that bookmark's coordinates with OSM

Support for Marble runners is not in the scope of this patch.

And parsing lonlat needs to be improved, still. WIP in another branch of mine.


Diffs (updated)
-----

  src/CMakeLists.txt b9b4a3b 
  src/QtMainWindow.h 8c3cfe3 
  src/QtMainWindow.cpp e57feca 
  src/kdemain.cpp eee55df 
  src/plasmarunner/CMakeLists.txt PRE-CREATION 
  src/plasmarunner/Messages.sh PRE-CREATION 
  src/plasmarunner/main.cpp PRE-CREATION 
  src/plasmarunner/plasma-runner-marble.desktop PRE-CREATION 
  src/plasmarunner/plasmarunner.h PRE-CREATION 
  src/plasmarunner/plasmarunner.cpp PRE-CREATION 
  src/qtmain.cpp 3d6d1c7 

Diff: http://git.reviewboard.kde.org/r/102849/diff/diff


Testing
-------

Used a few times.


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20111031/ef4f0097/attachment.html>