[Marble-devel] Review Request: Add speedometer plugin showing current travelling speed

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102961/#review7610
-----------------------------------------------------------



src/plugins/render/speedometer/Speedometer.cpp
<http://git.reviewboard.kde.org/r/102961/#comment6599>

    Why do you make a dynamic cast instead of a qobject_cast ?
    



src/plugins/render/speedometer/Speedometer.ui
<http://git.reviewboard.kde.org/r/102961/#comment6598>

    QLCD Number Widget is arguably the most ugly widget that Qt has to offer :-( It would be nice if we could replace this at one point in the future with quality graphics.
    Nice LCD numbers are always a bit tilted and pay attention to other details. Qt's LCD Number widget is pretty naive and technically done and just looks awkward :-/
    
    See e.g. 
    
    http://www.markinns.com/images/article_images/free-sample-lcd-numbers.png
    
    for a nice one that looks better (or google for "LCD Number").


- Torsten Rahn


On Oct. 24, 2011, 2:48 p.m., Bernhard Beschow wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102961/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2011, 2:48 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> This plugin allows Marble to be used as a speedometer. The current travelling speed is shown in big LCD letters, like on a bicycle computer.
> 
> Future versions could also show the travelled distance.
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/CMakeLists.txt 01405fa 
>   src/plugins/render/speedometer/CMakeLists.txt PRE-CREATION 
>   src/plugins/render/speedometer/Speedometer.h PRE-CREATION 
>   src/plugins/render/speedometer/Speedometer.cpp PRE-CREATION 
>   src/plugins/render/speedometer/Speedometer.ui PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102961/diff/diff
> 
> 
> Testing
> -------
> 
> Tested in-flight with the QtLocation positionprovider plugin. Speed values seem to be ok.
> 
> 
> Screenshots
> -----------
> 
> Speedometer
>   http://git.reviewboard.kde.org/r/102961/s/317/
> 
> 
> Thanks,
> 
> Bernhard Beschow
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20111025/88cb41cb/attachment.html>