[Marble-devel] Review Request: Plasma Runner which starts Marble for entered lonlat coordinates

[Friedrich W. H. Kossebau]

> On Oct. 15, 2011, 8:58 p.m., Torsten Rahn wrote:
> > src/kdemain.cpp, line 340
> > <http://git.reviewboard.kde.org/r/102849/diff/2/?file=38890#file38890line340>
> >
> >     That probably made you feel even more motivated about fixing the fromString method, right? ;-)

Right. But that is work in another branch, will take some more days before being complete :)

And some of the lonlat variants are successfully parsed, so that should not block this merge request I think.
It already adds value and works for what used to work in Marble as well, when entering the lonlat coords in the Search field.
Even more works fine with the bookmarks. For me at least :)


- Friedrich W. H.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102849/#review7358
-----------------------------------------------------------


On Oct. 16, 2011, 5:05 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102849/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2011, 5:05 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> Initial minimal version of my planned Plasma Runner. So far only detects lonlat coordinates and starts a new Marble showing that coordinates with OSM.
> Support for Marble runners and bookmarks is to come. And parsing needs to be improved, still. WIP.
> 
> Are commandline arguments for Marble okay?
> Discovers some rendering problems in Marble widget on start, someone might investigate that (no clue myself yet).
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt a0e4e7a 
>   src/kdemain.cpp eee55df 
>   src/plasmarunner/CMakeLists.txt PRE-CREATION 
>   src/plasmarunner/Messages.sh PRE-CREATION 
>   src/plasmarunner/main.cpp PRE-CREATION 
>   src/plasmarunner/plasma-runner-marble.desktop PRE-CREATION 
>   src/plasmarunner/plasmarunner.h PRE-CREATION 
>   src/plasmarunner/plasmarunner.cpp PRE-CREATION 
>   src/qtmain.cpp 3d6d1c7 
> 
> Diff: http://git.reviewboard.kde.org/r/102849/diff/diff
> 
> 
> Testing
> -------
> 
> Used a few times.
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20111016/90cd3e05/attachment.html>