[Marble-devel] Review Request: Plasma Runner which starts Marble for entered lonlat coordinates

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102849/
-----------------------------------------------------------

(Updated Oct. 16, 2011, 5:05 p.m.)


Review request for Marble.


Changes
-------

Updated patch has now also support for matching Marble bookmarks!

Also adds support for the new arguments "lonlat" and "map" to qtmain.cpp.
But: they do not work yet, as MainWindow::initObject() is only run when the main event loop is entered.
Worse, even sending the settings as "messages" as well by the event loop like
    QMetaObject::invokeMethod(window->marbleControl()->marbleWidget(),
                              "setMapThemeId", Qt::QueuedConnection,
                              Q_ARG(QString, mapThemeId));
does not help here, as MainWindow::initObject() calls 
    QCoreApplication::processEvents ();
before doing anything :(

Any idea how to solve that??? No idea why the code is that way.


Description
-------

Initial minimal version of my planned Plasma Runner. So far only detects lonlat coordinates and starts a new Marble showing that coordinates with OSM.
Support for Marble runners and bookmarks is to come. And parsing needs to be improved, still. WIP.

Are commandline arguments for Marble okay?
Discovers some rendering problems in Marble widget on start, someone might investigate that (no clue myself yet).


Diffs (updated)
-----

  src/CMakeLists.txt a0e4e7a 
  src/kdemain.cpp eee55df 
  src/plasmarunner/CMakeLists.txt PRE-CREATION 
  src/plasmarunner/Messages.sh PRE-CREATION 
  src/plasmarunner/main.cpp PRE-CREATION 
  src/plasmarunner/plasma-runner-marble.desktop PRE-CREATION 
  src/plasmarunner/plasmarunner.h PRE-CREATION 
  src/plasmarunner/plasmarunner.cpp PRE-CREATION 
  src/qtmain.cpp 3d6d1c7 

Diff: http://git.reviewboard.kde.org/r/102849/diff/diff


Testing
-------

Used a few times.


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20111016/d4f145b7/attachment-0001.html>