[Marble-devel] Review Request: Put MarbleMap::rotateBy() under test

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102877/#review7356
-----------------------------------------------------------

Ship it!


Ship It!

- Torsten Rahn


On Oct. 15, 2011, 8:11 p.m., Bernhard Beschow wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102877/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2011, 8:11 p.m.)
> 
> 
> Review request for Marble and Torsten Rahn.
> 
> 
> Description
> -------
> 
> This patch puts MarbleMap::rotateBy() under test. Since the current implementation produces unpredictable results, rotateBy() is modified such that the resulting LonLat equals currentLonLat + deltaLonLat, which seems to be the intention of the current implementation.
> 
> Questions:
> * does the new implementation really match the intention?
> * are there any test rows missing?
> 
> 
> Diffs
> -----
> 
>   src/lib/MarbleMap.cpp c4b40b1 
>   tests/MarbleMapTest.cpp 9a4ac8c 
> 
> Diff: http://git.reviewboard.kde.org/r/102877/diff/diff
> 
> 
> Testing
> -------
> 
> When centering on the north pole in spherical projection, the globe is rotated around the planet axis (running through north and south pole) when the mouse arrows appear. The patch preserves this behavior (although possibly with slightly different values).
> 
> 
> Thanks,
> 
> Bernhard Beschow
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20111015/3e187ff0/attachment.html>