[Marble-devel] Review Request: Extend LatLonEdit to also support editing in Decimal and DegMin notation

[Friedrich W. H. Kossebau]

Hi,

thanks for review, Torsten, pushed to master. But then I still have a problem:

Mercredi, le 12 octobre 2011, à 11:14, Torsten Rahn a écrit:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102831/#review7255
> -----------------------------------------------------------
> 
> Ship it!
> 
> 
> Ship It!
> 
> - Torsten Rahn
> 
> On Oct. 11, 2011, 6:20 p.m., Friedrich W. H. Kossebau wrote:
> > Description
> > -------
> > 
> > This patch extends LatLonEdit to optionally also show the coordinate in
> > decimal notation. As well as in a variant of DMS where secs are left out
> > and instead mins are given in floating point notation. I found this
> > variant being used in a few places on the internet, also as option in
> > Maemo Mapper ;) Actually the data which got me into this Marble hacking
> > were exactly in that format (from some GPS device). So I think that
> > should be supported as well. Problem is that the global enum AngleUnit
> > ATM only has {DMSDegree, DecimalDegree, UTM}. So it would need to be
> > extended. What do you think? What is the proper term for that "DM"
> > notation?
> > 
> > For support of UTM, I have not yet investigated, seems to be something
> > more complex and not yet used throughout Marble, or?
> > 
> > The patch also changes the EditBookmarkDialog to set the lon and lat
> > widgets to the notation of the map widget, if present. But only, if
> > present. And there is no widget present in case of the bookmarkseditor.
> > Any idea how I could get

Eh, somehow that end got lost, question was:

In the bookmark manager, rather BookmarkManagerDialog, I have no way ATM to 
get the current widget or the settings.
What would be your proposed way to get the setting for the notation in the 
BookmarkManagerDialog? Could not find a pattern so far.
Would need to set it with some new EditBookmarkDialog::setNotation(...) to the 
editor then. Or should EditBookmarkDialog read the default notation from the 
settings, and overwrite only with that of the passed widget?

Cheers
Friedrich