[Marble-devel] Review Request: Extend LatLonEdit to also support editing in Decimal and DegMin notation

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102831/
-----------------------------------------------------------

Review request for Marble.


Description
-------

This patch extends LatLonEdit to optionally also show the coordinate in decimal notation.
As well as in a variant of DMS where secs are left out and instead mins are given in floating point notation.
I found this variant being used in a few places on the internet, also as option in Maemo Mapper ;)
Actually the data which got me into this Marble hacking were exactly in that format (from some GPS device).
So I think that should be supported as well. Problem is that the global enum AngleUnit ATM only has {DMSDegree, DecimalDegree, UTM}.
So it would need to be extended. What do you think? What is the proper term for that "DM" notation?

For support of UTM, I have not yet investigated, seems to be something more complex and not yet used throughout Marble, or?

The patch also changes the EditBookmarkDialog to set the lon and lat widgets to the notation of the map widget, if present.
But only, if present. And there is no widget present in case of the bookmarkseditor. Any idea how I could get 


Diffs
-----

  src/lib/EditBookmarkDialog.cpp 32382b4 
  src/lib/LatLonEdit.h c81e380 
  src/lib/LatLonEdit.cpp 9af9cba 
  src/lib/LatLonEdit.ui 628a5f2 

Diff: http://git.reviewboard.kde.org/r/102831/diff/diff


Testing
-------

Running Marble, switching the settings and creating bookmarks a few times.


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20111011/35ef381b/attachment.html>