[Marble-devel] Review Request: Unify measurement system and distance units in MarbleLocale

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103295/#review8609
-----------------------------------------------------------


Is there a reason why some methods are called "measureSystem" instead of "measurementSystem"? Would be more consistent. Apart from that the patch looks fine to me.

- Torsten Rahn


On Nov. 30, 2011, 11:53 a.m., Bernhard Beschow wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103295/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2011, 11:53 a.m.)
> 
> 
> Review request for Marble and Torsten Rahn.
> 
> 
> Description
> -------
> 
> Having both distanceUnit() and measureSystem() in the API creates ambiguities for programmers. In addition, distanceUnit() and measureSystem() could refer to different measure systems, leading to inconsistencies in Marble. It makes therefore sense to unify DistanceUnit and the measure system.
> 
> This patch replaces all usages of DistanceUnit by QLocale::MeasurementSystem and removes the respective methods from MarbleLocale.
> 
> 
> Diffs
> -----
> 
>   src/QtMainWindow.cpp 011f080 
>   src/lib/MarbleLocale.h cb55542 
>   src/lib/MarbleLocale.cpp a970dd3 
>   src/lib/MarbleLocale_p.h 9702970 
>   src/lib/MarbleWidget.cpp 717791c 
>   src/lib/QtMarbleConfigDialog.h 04ebee6 
>   src/lib/QtMarbleConfigDialog.cpp 6ae77f5 
>   src/lib/TinyWebBrowser.cpp f0a2a66 
>   src/lib/global.h 778c991 
>   src/lib/layers/MeasureTool.cpp 56691f0 
>   src/marble.kcfg 06277c8 
>   src/marble_part.cpp b77aeef 
>   src/plugins/render/elevationprofile/ElevationProfileFloatItem.cpp af5b5b7 
>   src/plugins/render/gpsinfo/GpsInfo.cpp f0a7eb8 
>   src/plugins/render/mapscale/MapScaleFloatItem.cpp ba05324 
>   src/plugins/render/routing/RoutingPlugin.cpp 40ec8d8 
>   src/plugins/render/speedometer/Speedometer.cpp d0accaa 
>   src/plugins/runner/local-osm-search/OsmDatabase.cpp d2c976c 
> 
> Diff: http://git.reviewboard.kde.org/r/103295/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bernhard Beschow
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20111130/b088a878/attachment.html>