[Marble-devel] Review Request: Adds Measure Tool Plugin, with all of the functionality of the Measure tool.

[Mike Henning]

> On Nov. 27, 2011, 1:27 p.m., Dennis Nienhüser wrote:
> > src/plugins/render/measure/MeasureToolPlugin.cpp, line 158
> > <http://git.reviewboard.kde.org/r/103262/diff/1/?file=42230#file42230line158>
> >
> >     A fixed size array looks so C-ish :-/
> >     I know it's not your code, but maybe we should refactor this one.
> >

Left this one as is because I couldn't think of a better way to do this without modifying a decent amount of code.

Looking closer, I noticed that this function was declaring two different variables named "it" (even while the first was still in scope! I was surprised that it even complied.), so I renamed one of them.


- Mike


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103262/#review8519
-----------------------------------------------------------


On Nov. 27, 2011, 8:16 p.m., Mike Henning wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103262/
> -----------------------------------------------------------
> 
> (Updated Nov. 27, 2011, 8:16 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> Adds Measure Tool Plugin, with all of the functionality of the Measure tool.
> 
> This patch depends on https://git.reviewboard.kde.org/r/103261/
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/CMakeLists.txt de8e5e5 
>   src/plugins/render/measure/CMakeLists.txt PRE-CREATION 
>   src/plugins/render/measure/MeasureToolPlugin.h PRE-CREATION 
>   src/plugins/render/measure/MeasureToolPlugin.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/103262/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mike Henning
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20111127/e19dfe3f/attachment-0001.html>