[Marble-devel] Review Request: Add lastRmbPos member to MarbleWidgetPopupMenu, to allow plugins to access the menu's position.

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103261/#review8518
-----------------------------------------------------------



src/lib/MarbleWidgetPopupMenu.h
<http://git.reviewboard.kde.org/r/103261/#comment7221>

    Please move to the private section of the class and name it m_mousePosition. Then add an accessor for it in the public section
    QPoint mousePosition() const.
    The position should be stored for both the left and the right popup menu (since both won't be active at the same time and being able to access the position for the left menu is useful as well)
    



src/lib/MarbleWidgetPopupMenu.cpp
<http://git.reviewboard.kde.org/r/103261/#comment7222>

    Same for the left menu, see comment above.


- Dennis Nienhüser


On Nov. 26, 2011, 11:37 p.m., Mike Henning wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103261/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2011, 11:37 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> Add lastRmbPos member to MarbleWidgetPopupMenu, to allow plugins to access the menu's position.
> 
> 
> Diffs
> -----
> 
>   src/lib/MarbleWidgetPopupMenu.h 2099dde 
>   src/lib/MarbleWidgetPopupMenu.cpp 3b1d991 
> 
> Diff: http://git.reviewboard.kde.org/r/103261/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mike Henning
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20111127/c9259ceb/attachment.html>