[Marble-devel] Review Request: rework lmb and rmb menus

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103053/#review8455
-----------------------------------------------------------


This review has been submitted with commit 0613cbb9dd4d3db3a5d6963c938221ab9bd7b03c by Bernhard Beschow to branch master.

- Commit Hook


On Nov. 16, 2011, 7:41 p.m., Bernhard Beschow wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103053/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2011, 7:41 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> The lmb as well as the rmb menu offer actions regarding the current geo position. In particular, the lmb menu offers "Copy Coordinates" and "Address Details", while the rmb menu offers "Add Bookmark" and "Set Home Location". As a result, neither of the menus have precise duties, creating ambiguities, which this patch addresses. Moreover, this patch also addresses bug 282394.
> 
> The changes in the patch include:
> * concentrate all actions regarding the current geo position in the rmb menu
> * remove unimplemented planet action
> * use the lmb menu only for resolving ambiguities when opening links
> 
> The lmb menu only appears when there are ambiguities. Otherwise, the internal browser is opened immediately or the lmb menu is ignored when there are no actions available.
> 
> The rmb menu got a new sub menu which includes the four actions from above. See screenshot for details.
> 
> 
> This addresses bug 282394.
>     http://bugs.kde.org/show_bug.cgi?id=282394
> 
> 
> Diffs
> -----
> 
>   src/lib/MarbleWidgetPopupMenu.h c31f14e 
>   src/lib/MarbleWidgetPopupMenu.cpp d3607de 
> 
> Diff: http://git.reviewboard.kde.org/r/103053/diff/diff
> 
> 
> Testing
> -------
> 
> The menus make more sense.
> 
> 
> Screenshots
> -----------
> 
> LMB menu resolving ambiguities
>   http://git.reviewboard.kde.org/r/103053/s/324/
> new RMB menu
>   http://git.reviewboard.kde.org/r/103053/s/337/
> 
> 
> Thanks,
> 
> Bernhard Beschow
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20111124/86c5798a/attachment.html>