[Marble-devel] Review Request: Preview Map feature for Map Wizard

Bernhard Beschow bbeschow at cs.tu-berlin.de
Mon Nov 21 14:21:27 UTC 2011



> On Nov. 17, 2011, 3:38 p.m., Bernhard Beschow wrote:
> > Ok, the navigator on the left works as well.
> > 
> > Still two things:
> > 
> > In order to maximize screen usage, I think you should remove all spacing and margins, such that there is no space between the border of the preview dialog and its content, and no (additional) space between the navigator and MarbleWidget.
> > 
> > When closing the preview dialog, the focus issue still prevails: I can't click any button in the wizard unless I move the wizard around. Does it happen for you as well?
> 
> Utku Aydın wrote:
>     I tried it several times, focus returns to wizard's "Preview Map" button when I close the dialog.

Ok, I'm able to click any button as soon as the MarbleWidget is completely unloaded. So no problems on your side. :)


- Bernhard


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103146/#review8273
-----------------------------------------------------------


On Nov. 17, 2011, 4:13 p.m., Utku Aydın wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103146/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2011, 4:13 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> Added preview map feature for Map Wizard.
> 
> 
> Diffs
> -----
> 
>   src/lib/MapWizard.h 50776bf 
>   src/lib/MapWizard.cpp 9ebd686 
>   src/lib/MapWizard.ui 880b86c 
> 
> Diff: http://git.reviewboard.kde.org/r/103146/diff/diff
> 
> 
> Testing
> -------
> 
> Tested with a newly created map from a bitmap image.
> 
> 
> Screenshots
> -----------
> 
> Preview Map Dialog
>   http://git.reviewboard.kde.org/r/103146/s/342/
> 
> 
> Thanks,
> 
> Utku Aydın
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20111121/3b8dfaed/attachment.html>


More information about the Marble-devel mailing list