[Marble-devel] Review Request: have GeometryLayer and PlacemarkLayout connect() themselves

[Bernhard Beschow]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103167/
-----------------------------------------------------------

Review request for Marble and Thibaut Gridel.


Description
-------

GeometryLayer and PlacemarkLayout are currently wired up in MarbleMap. Since MarbleMap is basically a container for layers, it shouldn't have to know about implementation details of any specific layer. Therefore, the connect() statements should move into the respective layers themselves.

Before the connections can be wired up in the layers, a change to GeoDataTreeModel should be made: The treeChanged() signal seems redundant to QAbstractItemModel::layoutChanged(), and is currently only used for updating GeometryLayer and PlacemarkLayout. Therefore, GeoDataTreeModel can emit layoutChanged() such that treeChanged() can be removed.


Diffs
-----

  src/lib/GeoDataTreeModel.h fa919ba 
  src/lib/GeoDataTreeModel.cpp 3056153 
  src/lib/MarbleMap.cpp 3eb5a76 
  src/lib/layers/GeometryLayer.cpp 53b5c32 
  src/lib/layers/PlacemarkLayout.cpp 6cf3943 

Diff: http://git.reviewboard.kde.org/r/103167/diff/diff


Testing
-------

Works for me. I'm not sure whether all changes of the models are correctly caught by the layers, esp. in the PlacemarkLayer. Please report any issues you see. Thx!


Thanks,

Bernhard Beschow

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20111117/56164757/attachment.html>