[Marble-devel] Review Request: rework lmb and rmb menus

[Bernhard Beschow]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103053/
-----------------------------------------------------------

(Updated Nov. 15, 2011, 2:40 p.m.)


Review request for Marble.


Changes
-------

Updated to latest master. Due to significant changes in master, disambiguation of features is not performed any more.

The coordinates in the rmb menu looked to technical IMO. My initial idea was to remove the sub menu completely, including the "address details" and "copy coordinate" actions. However, after talking to Torsten, I kept those actions, moving them into the rmb menu itself. These two actions *replace* the "set home point" and "add bookmark" actions in the current rmb menu, which I believe are extremely seldom respectively not heavily used, and where actions in the application menu are available.


Description
-------

The lmb as well as the rmb menu offer actions regarding the current geo position. In particular, the lmb menu offers "Copy Coordinates" and "Address Details", while the rmb menu offers "Add Bookmark" and "Set Home Location". As a result, neither of the menus have precise duties, creating ambiguities, which this patch addresses. Moreover, this patch also addresses bug 282394.

The changes in the patch include:
* concentrate all actions regarding the current geo position in the rmb menu
* remove unimplemented planet action
* use the lmb menu only for resolving ambiguities when opening links

The lmb menu only appears when there are ambiguities. Otherwise, the internal browser is opened immediately or the lmb menu is ignored when there are no actions available.

The rmb menu got a new sub menu which includes the four actions from above. See screenshot for details.


This addresses bug 282394.
    http://bugs.kde.org/show_bug.cgi?id=282394


Diffs (updated)
-----

  src/lib/MarbleWidgetPopupMenu.h c31f14e 
  src/lib/MarbleWidgetPopupMenu.cpp d3607de 

Diff: http://git.reviewboard.kde.org/r/103053/diff/diff


Testing
-------

The menus make more sense.


Screenshots
-----------

LMB menu resolving ambiguities
  http://git.reviewboard.kde.org/r/103053/s/324/
new RMB menu
  http://git.reviewboard.kde.org/r/103053/s/325/


Thanks,

Bernhard Beschow

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20111115/7b9ff27b/attachment.html>