[Marble-devel] Review Request: Kinetic spinning for Marble

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6171/#review10467
-----------------------------------------------------------

Ship it!


Thanks. I just committed this patch.

It works nicely here. I don't think we need an option to disable it assuming we iron out any annoyances we might come across. Applying https://git.reviewboard.kde.org/r/103053/ for example to avoid having a popup menu come up when stopping the spinning.

Can you please close this review request?

- Dennis Nienhüser


On Dec. 20, 2010, 3:14 p.m., Ariya Hidayat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6171/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2010, 3:14 p.m.)
> 
> 
> Review request for marble.
> 
> 
> Description
> -------
> 
> This patch adds kinetic spinning support. It is still rough and may require some polishes.
> 
> Also, I'm still not sure whether we need a property in MarbleWidget to disable/enable the behavior.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/lib/CMakeLists.txt 1208062 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleWidgetInputHandler.h 1208062 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleWidgetInputHandler.cpp 1208062 
>   /trunk/KDE/kdeedu/marble/src/lib/kineticmodel.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/lib/kineticmodel.cpp PRE-CREATION 
> 
> Diff: http://svn.reviewboard.kde.org/r/6171/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ariya Hidayat
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20111113/5e097a6e/attachment.html>