[Marble-devel] Review Request: Added support for the <gx:Track> kml tag via GeoDataTrack

[Niko Sams]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103081/#review8030
-----------------------------------------------------------


I did some work based on this patch (added ExtendedData to GeoDataTrack, gpx track parsing) so I'm very glad to see this merge request, hopefully it gets accepted.

Related to the patch, I created an unit test that puts the parser part of this patch under test:
http://quickgit.kde.org/?p=clones%2Fmarble%2Fnsams%2Fmarble.git&a=commit&h=f20215229b18d762db7f567c07d8a21872cfabf5


src/lib/geodata/data/GeoDataTrack.cpp
<http://git.reviewboard.kde.org/r/103081/#comment6917>

    this inserts the corrdinates in reverse order; it should be takeFirst()
    (same with appendCoordinates)


- Niko Sams


On Nov. 8, 2011, 5:12 p.m., Guillaume Martres wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103081/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2011, 5:12 p.m.)
> 
> 
> Review request for Marble and Thibaut Gridel.
> 
> 
> Description
> -------
> 
> This is used in the Satellites plugin and could be used for routing and elsewhere.
> 
> 
> Diffs
> -----
> 
>   src/QtMainWindow.cpp 851472c 
>   src/lib/FileLoader.cpp ebda20b 
>   src/lib/MarbleClock.h e8d9217 
>   src/lib/MarbleMap.cpp 06bc20d 
>   src/lib/MarbleWidget.cpp 0719e8b 
>   src/lib/MarbleWidgetPopupMenu.cpp 762c406 
>   src/lib/PlacemarkInfoDialog.h e9f8f47 
>   src/lib/PlacemarkInfoDialog.cpp d551d2f 
>   src/lib/geodata/data/GeoDataLineString.cpp 79b0180 
>   src/lib/geodata/data/GeoDataPlacemark.h 46842d7 
>   src/lib/geodata/data/GeoDataPlacemark.cpp 14634ed 
>   src/lib/geodata/data/GeoDataTrack.h PRE-CREATION 
>   src/lib/geodata/data/GeoDataTrack.cpp PRE-CREATION 
>   src/lib/geodata/data/Serializable.h db1e5ad 
>   src/lib/geodata/graphicsitem/GeoTrackGraphicsItem.h PRE-CREATION 
>   src/lib/geodata/graphicsitem/GeoTrackGraphicsItem.cpp PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlAltitudeModeTagHandler.cpp a57a694 
>   src/lib/geodata/handlers/kml/KmlCoordinatesTagHandler.cpp a62d757 
>   src/lib/geodata/handlers/kml/KmlElementDictionary.h 0efb3d7 
>   src/lib/geodata/handlers/kml/KmlElementDictionary.cpp 7081526 
>   src/lib/geodata/handlers/kml/KmlTrackTagHandler.h PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlTrackTagHandler.cpp PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlWhenTagHandler.cpp 7f0f0ae 
>   src/lib/geodata/parser/GeoDataParser.cpp bd3f71c 
>   src/lib/geodata/parser/GeoDataTypes.h cae1451 
>   src/lib/geodata/parser/GeoDataTypes.cpp e85dd4e 
>   src/lib/geodata/writer/GeoWriter.h 953fedf 
>   src/lib/geodata/writer/GeoWriter.cpp ef64ecf 
>   src/lib/geodata/writers/kml/KmlTrackWriter.h PRE-CREATION 
>   src/lib/geodata/writers/kml/KmlTrackWriter.cpp PRE-CREATION 
>   src/lib/layers/GeometryLayer.cpp 8eb86c8 
>   src/lib/layers/PlacemarkLayout.h 082e8ee 
>   src/lib/layers/PlacemarkLayout.cpp cdea897 
>   src/plugins/positionprovider/placemark/PlacemarkPositionProviderPlugin.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/103081/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guillaume Martres
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20111108/84276def/attachment.html>