[Marble-devel] Review Request: Make the MarbleClock update interval configurable.

Torsten Rahn tackat at kde.org
Tue Nov 8 13:32:25 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103065/#review8021
-----------------------------------------------------------

Ship it!


Looks good to me. I dislike having a mere implementation detail (refresh interval)  in the UI but I see why it's necessary.

- Torsten Rahn


On Nov. 7, 2011, 8:48 p.m., Guillaume Martres wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103065/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2011, 8:48 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> This adds a "Refresh Interval" QSpinBox to the TimeControlWidget and an updateInterval() property to MarbleClock.
> 
> 
> Diffs
> -----
> 
>   src/lib/MarbleClock.h e8d9217 
>   src/lib/MarbleClock.cpp 7a9ca29 
>   src/lib/TimeControlWidget.h 4d3baff 
>   src/lib/TimeControlWidget.cpp ef664ee 
>   src/lib/TimeControlWidget.ui 6808399 
> 
> Diff: http://git.reviewboard.kde.org/r/103065/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guillaume Martres
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20111108/3249158d/attachment.html>


More information about the Marble-devel mailing list