[Marble-devel] Review Request: Fix GeoDataCoordinates::fromString(...)

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103000/#review7982
-----------------------------------------------------------

Ship it!


Ship It!

- Torsten Rahn


On Nov. 6, 2011, 7:08 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103000/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2011, 7:08 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> Fixes GeoDataCoordinates::fromString(...) by a rewrite of parsing code.
> Turned parsing code into a parser class, named LatLonParser.
> 
> Supports parsing of D, DM, and DMS:
> * last unit can be in floating point precision
> * directions can be in local language, fallback to english if not matching
> * accepts plain ASCII chars ' " as well as chars ? (PRIME) and ? (DOUBLE PRIME).
> 
> 
> Diffs
> -----
> 
>   src/lib/geodata/data/GeoDataCoordinates.cpp a0a2436 
>   tests/unittest_geodatacoordinates.cpp 10f2d94 
> 
> Diff: http://git.reviewboard.kde.org/r/103000/diff/diff
> 
> 
> Testing
> -------
> 
> Patch adds 3 new unit tests which all pass.
> Also entered coordinates in lots of different formats to my Plasma Marble Runner, worked fine.
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20111106/7472e142/attachment-0001.html>