[Marble-devel] Review Request: Keep zoom value when selecing placemark in GoToDialog
Commit Hook
null at kde.org
Fri Nov 4 13:34:49 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102979/#review7944
-----------------------------------------------------------
This review has been submitted with commit ed9060d09b3c8ccd2ced47a5f93ff70a2064a624 by Bernhard Beschow to branch master.
- Commit Hook
On Oct. 27, 2011, 5:45 p.m., Bernhard Beschow wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102979/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2011, 5:45 p.m.)
>
>
> Review request for Marble and Dennis Nienhüser.
>
>
> Description
> -------
>
> When selecing a placemark in the GoToDialog, Marble currently changes the zoom to a rather high value. So when searching for a city, e.g. Berlin, a very small area is shown, even when whole Berlin was visible.
>
> Leaving the zoom value untouched when selecting a placemark in the GoToDialog, the user is able to select the desired zoom value upfront, and navigate to different search results w/o having to restore the desired zoom value. This is useful when looking for villages with the same name, especially on the N900.
>
>
> Diffs
> -----
>
> src/QtMainWindow.cpp e57feca
> src/lib/GoToDialog.h 8fea35e
> src/lib/GoToDialog.cpp 2d10919
> src/lib/routing/RoutingInputWidget.cpp 870dd05
>
> Diff: http://git.reviewboard.kde.org/r/102979/diff/diff
>
>
> Testing
> -------
>
> Seems to work, the current zoom value is preserved.
>
>
> Thanks,
>
> Bernhard Beschow
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20111104/df283392/attachment-0001.html>
More information about the Marble-devel
mailing list