[Marble-devel] Re: Review Request: Use the Qt gesture framework for pinch zoom

[Bernhard Beschow]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101417/#review3479
-----------------------------------------------------------

Ship it!


Works nice here on an Asus EEEPC 1000H. Great work!


src/lib/MarbleWidgetInputHandler.cpp
<http://git.reviewboard.kde.org/r/101417/#comment2939>

    Is this include statement still needed?


- Bernhard


On May 22, 2011, 2:43 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101417/
> -----------------------------------------------------------
> 
> (Updated May 22, 2011, 2:43 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Summary
> -------
> 
> at start, the multitouch pinch zoom in marble was implemented with raw qtouchevent because the gesture framework still wasn't available.
> this patch changes marble to use the factory pinch gesture, that simplifies a bit the code and should give a more coherent behaviour compared to other apps that use the same stock gesture.
> 
> 
> Diffs
> -----
> 
>   src/lib/MarbleWidget.cpp 39eb47a 
>   src/lib/MarbleWidgetInputHandler.cpp 2a31a8b 
> 
> Diff: http://git.reviewboard.kde.org/r/101417/diff
> 
> 
> Testing
> -------
> 
> tested on meego on a lenovo ideapad. the amount of zooming now seems matematically more correct after the gesture.
> 
> with both old and new code there is an ugly delay during zooming, that is probably due to a misbehaviour in the qt multitouch itself (either too much or not enough events arriving), it's probably not depended from marble itself, it should be tried either on mac or windows to see if the problem is present also where multitouch is better supported in Qt
> 
> 
> Thanks,
> 
> Marco
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20110524/c8fc9306/attachment-0001.htm