[Marble-devel] Re: Review Request: Offline OpenStreetMap Address Search

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101245/#review3107
-----------------------------------------------------------


This review has been submitted with commit 8aab14a292d4386d11d163e078b00c817dc8eff8 by Dennis Nienhüser.

- Commit


On May 3, 2011, 10:24 p.m., Dennis Nienhüser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101245/
> -----------------------------------------------------------
> 
> (Updated May 3, 2011, 10:24 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Summary
> -------
> 
> This is the initial version of a search runner plugin that adds offline address search. I thought I'd rather push it now in an earlier stage to have the majority of the code in place before the upcoming freezes.
> 
> The patch contains the reading part: A runner plugin for Marble that works on one or more placemarks.dat files found somewhere in $MARBLE_DATADIR/maps/earth/monav/. I plan to extend the existing monav offline maps by such $country.sqlite files once the file format is reasonably stable. I'll commit the writing part (.osm parser and preprocessing) at a later point. It's only used to create .sqlite files, i.e. doesn't affect the Marble code.
> 
> 
> Diffs
> -----
> 
>   src/lib/GoToDialog.h 62c358f 
>   src/lib/GoToDialog.cpp caeff72 
>   src/lib/GoToDialog.ui f0756a3 
>   src/plugins/runner/CMakeLists.txt e63407a 
>   src/plugins/runner/local-osm-search/CMakeLists.txt PRE-CREATION 
>   src/plugins/runner/local-osm-search/DatabaseQuery.h PRE-CREATION 
>   src/plugins/runner/local-osm-search/DatabaseQuery.cpp PRE-CREATION 
>   src/plugins/runner/local-osm-search/LocalOsmSearchPlugin.h PRE-CREATION 
>   src/plugins/runner/local-osm-search/LocalOsmSearchPlugin.cpp PRE-CREATION 
>   src/plugins/runner/local-osm-search/LocalOsmSearchRunner.h PRE-CREATION 
>   src/plugins/runner/local-osm-search/LocalOsmSearchRunner.cpp PRE-CREATION 
>   src/plugins/runner/local-osm-search/OsmDatabase.h PRE-CREATION 
>   src/plugins/runner/local-osm-search/OsmDatabase.cpp PRE-CREATION 
>   src/plugins/runner/local-osm-search/OsmPlacemark.h PRE-CREATION 
>   src/plugins/runner/local-osm-search/OsmPlacemark.cpp PRE-CREATION 
>   src/plugins/runner/local-osm-search/OsmRegion.h PRE-CREATION 
>   src/plugins/runner/local-osm-search/OsmRegion.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/101245/diff
> 
> 
> Testing
> -------
> 
> Mostly with http://nienhueser.de/marble/hamburg.sqlite (3.3 MB). Place that file in ~/.local/share/marble/placemarks/ and search for streets or places in Hamburg to see it running. Notice that the file format / db layout may still change a bit in the future. See http://userbase.kde.org/Marble/OfflineSearch for features expected to work.
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/101245/s/156/
> 
> 
> Thanks,
> 
> Dennis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20110504/f318de70/attachment-0001.htm