[Marble-devel] Re: Review Request: Fix sunlight and timezone display in the worldclock plasmoid.

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6622/#review9997
-----------------------------------------------------------

Ship it!


Looks good to me. :-) 

- Torsten


On March 20, 2011, 6:29 p.m., Cristian Onet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6622/
> -----------------------------------------------------------
> 
> (Updated March 20, 2011, 6:29 p.m.)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> This patch fixes the following issues (found using KDE 4.6.1):
> 1. The sunlight is always displayed incorrectly (at some unknown time)
> 2. When the widget is initially displayed it shows some timezone which is nearest to the center of the map
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/plasmoid/worldclock.h 1225392 
>   /trunk/KDE/kdeedu/marble/src/plasmoid/worldclock.cpp 1225392 
> 
> Diff: http://svn.reviewboard.kde.org/r/6622/diff
> 
> 
> Testing
> -------
> 
> View the plasmoid with plasmoidviewer and checked that the reported issues are fixed.
> 
> 
> Thanks,
> 
> Cristian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20110320/3b68fbc4/attachment.htm