[Marble-devel] Re: Review Request: Fix compilation of QtMobilityPositionProviderPlugin

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101676/#review4017
-----------------------------------------------------------

Ship it!


Looks good. When committing, please make sure to note that even though a FindXY.cmake file is added, this is _not_ a dependency change (which would violate dependency freeze).


FindQtLocation.cmake
<http://git.reviewboard.kde.org/r/101676/#comment3282>

    Please do a consistent capitalization for cmake commands. Preferably all in capitals:
    FIND_PACKAGE
    IF
    ENDIF


- Dennis


On June 18, 2011, 6:44 p.m., Daniel Marth wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101676/
> -----------------------------------------------------------
> 
> (Updated June 18, 2011, 6:44 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Summary
> -------
> 
> Improved CMake-files to fix the compilation of QtMobilityPositionProviderPlugin, which is based on QtLocation in QtMobility.
> 
> 
> Diffs
> -----
> 
>   FindQtLocation.cmake 36f7748 
>   FindQtMobility.cmake PRE-CREATION 
>   src/plugins/positionprovider/CMakeLists.txt e1d06b9 
>   src/plugins/positionprovider/qtmobility/CMakeLists.txt 57f9f7a 
> 
> Diff: http://git.reviewboard.kde.org/r/101676/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20110618/904c12d5/attachment.htm