[Marble-devel] Review Request: Move PlacemarkLayout to LayerManager infrastructure

[Bernhard Beschow]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101842/
-----------------------------------------------------------

Review request for Marble and Thibaut Gridel.


Summary
-------

This patch makes PlacemarkLayout implement LayerInterface, such that it can be rendered as part of the LayerManager infrastructure.

Due to LayerInterface::render() taking a ViewportParams instead of a ViewParams argument, determining the visibility of placemarks is now performed in MarbleMap rather than in PlacemarkLayout. Since PlacemarkLayout now holds the visibility state of placemarks, it becomes independent of any GeoScene* classes, which should make it more robust w.r.t. dereferencing GeoSceneDocument *, which may be 0.


Diffs
-----

  src/lib/MarbleMap.h edbd2b0 
  src/lib/MarbleMap.cpp f641c16 
  src/lib/PlacemarkLayout.h 4b8c570 
  src/lib/PlacemarkLayout.cpp b5f0819 

Diff: http://git.reviewboard.kde.org/r/101842/diff


Testing
-------

Tested with Plain Map toggling placemark visibility in the legend.


Thanks,

Bernhard

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20110703/691130db/attachment.htm