[Marble-devel] Re: Review Request: Replace WMS Maps ComboBox with a ListWidget

[Bernhard Beschow]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101813/#review4353
-----------------------------------------------------------

Ship it!


Seems to work nice and improves the visual appearance of the available-maps-page. Please commit! :)

Since you didn't introduce new strings, you could consider backporting this patch to the kde-4.7 branch.

For the master branch, I recommend to add some discriptive text above the list view, similar to the other pages. This should be another patch, however.

- Bernhard


On July 1, 2011, 6:40 a.m., Utku Aydın wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101813/
> -----------------------------------------------------------
> 
> (Updated July 1, 2011, 6:40 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Summary
> -------
> 
> Replaced WMS Maps ComboBox with a ListWidget so the user can see all of the maps on the server when he/she is choosing one.
> 
> 
> Diffs
> -----
> 
>   src/lib/MapWizard.cpp 39914e2 
>   src/lib/MapWizard.ui cb53a8b 
> 
> Diff: http://git.reviewboard.kde.org/r/101813/diff
> 
> 
> Testing
> -------
> 
> Created new maps.
> 
> 
> Thanks,
> 
> Utku
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20110703/2fe73454/attachment.htm