[Marble-devel] Re: Review Request: GeoDataDocument role

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6418/#review9744
-----------------------------------------------------------

Ship it!


Looks good to me.


/trunk/KDE/kdeedu/marble/src/lib/FileLoader.cpp
<http://svn.reviewboard.kde.org/r/6418/#comment10901>

    I think
    
    FileLoader(
     const QString &file,
     DocumentRole role = UnknownDocument,
     QObject* parent = 0 )
    
    would be more convenient and Qt-style.



/trunk/KDE/kdeedu/marble/src/lib/geodata/parser/GeoDataTypes.h
<http://svn.reviewboard.kde.org/r/6418/#comment10900>

    Somehow I prefer TrackDocument to TrackingDocument. Maybe also add a RouteDocument value?
    


- Dennis


On Jan. 27, 2011, 9:47 p.m., Thibaut Gridel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6418/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2011, 9:47 p.m.)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> Provide a role to geodata documents, opening the door to selective use of geodata.
> For instance, filtering user-centric documents only in file view, marking map placemarks as read-only etc etc
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/lib/BookmarkManager.cpp 1217555 
>   /trunk/KDE/kdeedu/marble/src/lib/FileLoader.h 1217555 
>   /trunk/KDE/kdeedu/marble/src/lib/FileLoader.cpp 1217555 
>   /trunk/KDE/kdeedu/marble/src/lib/FileManager.h 1217555 
>   /trunk/KDE/kdeedu/marble/src/lib/FileManager.cpp 1217555 
>   /trunk/KDE/kdeedu/marble/src/lib/FileViewModel.cpp 1217555 
>   /trunk/KDE/kdeedu/marble/src/lib/GeoDataTreeModel.cpp 1217555 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleModel.cpp 1217555 
>   /trunk/KDE/kdeedu/marble/src/lib/PositionTracking.cpp 1217555 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataDocument.h 1217555 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataDocument.cpp 1217555 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataDocument_p.h 1217555 
>   /trunk/KDE/kdeedu/marble/src/lib/geodata/parser/GeoDataTypes.h 1217555 
> 
> Diff: http://svn.reviewboard.kde.org/r/6418/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thibaut
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20110128/27904485/attachment.htm