[Marble-devel] Review Request: Stackable Windows

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6417/
-----------------------------------------------------------

Review request for marble.


Summary
-------

Changes the dialogs used on the N900 into stackable windows. Stackable Windows are special Maemo windows that slide in and out when shown/hidden. They conserve some space compared to dialogs because the button to close the window is on the top right. The patch also transforms the search result and routing directions list view into a stackable window. Besides looking better this has the huge advantage that there are no two competing scrollable cascading windows anymore in the routing widget. Stackable Windows also allow to use custom actions (like in the main window) which is used for the routing dialog/window (Actions: Open Route, Save Route, Reverse Route).


Diffs
-----

  trunk/KDE/kdeedu/marble/src/CMakeLists.txt 1216524 
  trunk/KDE/kdeedu/marble/src/QtMainWindow.h 1216524 
  trunk/KDE/kdeedu/marble/src/QtMainWindow.cpp 1216524 
  trunk/KDE/kdeedu/marble/src/StackableWindow.h PRE-CREATION 
  trunk/KDE/kdeedu/marble/src/StackableWindow.cpp PRE-CREATION 
  trunk/KDE/kdeedu/marble/src/lib/routing/RoutingManager.h 1216524 
  trunk/KDE/kdeedu/marble/src/lib/routing/RoutingProfileSettingsDialog.cpp 1216524 
  trunk/KDE/kdeedu/marble/src/lib/routing/RoutingWidget.h 1216524 
  trunk/KDE/kdeedu/marble/src/lib/routing/RoutingWidget.cpp 1216524 
  trunk/KDE/kdeedu/marble/src/lib/routing/RoutingWidget.ui 1216524 

Diff: http://svn.reviewboard.kde.org/r/6417/diff


Testing
-------

Works fine in scratchbox, Desktop UI remains unchanged.


Screenshots
-----------

Stackable Windows (1)
  http://svn.reviewboard.kde.org/r/6417/s/608/
Stackable Windows (2)
  http://svn.reviewboard.kde.org/r/6417/s/609/
Stackable Windows (3)
  http://svn.reviewboard.kde.org/r/6417/s/610/
Stackable Windows (4)
  http://svn.reviewboard.kde.org/r/6417/s/611/


Thanks,

Dennis

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20110126/150eb999/attachment.htm