[Marble-devel] Re: Review Request: Full Edit Support for the Bookmark Manager

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6411/
-----------------------------------------------------------

(Updated Jan. 23, 2011, 9 p.m.)


Review request for marble.


Changes
-------

Add bug number.


Summary
-------

This patch makes the bookmark manager nearly complete: You can delete folders, rename them, create new ones, delete bookmarks and edit bookmarks (including moving to other folders). It also adds support for importing .kml files. The only missing thing -- which I plan to make a junior job -- is drag & drop support. (Internal move to change the order of folders and bookmarks inside folders. Maybe also D&D between views to support dragging bookmarks quickly to other folders.)

Squashed patch of a local git branch:
- Support importing bookmarks from .kml files. When conflicts arise (imported bookmark already exists), the user is asked whether to skip the new or replace the existing bookmark.
- NewFolderInfoDialog is a misleading name. Rename it NewBookmarkFolderDialog.
- Rename NameDialog to NewBookmarkFolderDialog, the former is too generic. Fix broken license header in NewBookmarkFolderDialog.h. Make it possible to use the dialog without changing existing bookmarks directly. Use a ButtonBox in the .ui to get a consistent interface.
- New bookmark folders can be created within the bookmark manager.
- Deletion of individual folders and bookmarks. Use the first folder as default selection.
- Use the existing dialogs to edit bookmark folders and bookmarks in the bookmark manager.
- Rename BookmarkInfoDialog to EditBookmarkDialog which describes its purpose better.


This addresses bug 261124.
    https://bugs.kde.org/show_bug.cgi?id=261124


Diffs
-----

  trunk/KDE/kdeedu/marble/src/QtMainWindow.h 1216047 
  trunk/KDE/kdeedu/marble/src/QtMainWindow.cpp 1216047 
  trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.h 1216047 
  trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.cpp 1216047 
  trunk/KDE/kdeedu/marble/src/lib/BookmarkInfoDialog.ui 1216047 
  trunk/KDE/kdeedu/marble/src/lib/BookmarkManager.cpp 1216047 
  trunk/KDE/kdeedu/marble/src/lib/BookmarkManagerDialog.h 1216047 
  trunk/KDE/kdeedu/marble/src/lib/BookmarkManagerDialog.cpp 1216047 
  trunk/KDE/kdeedu/marble/src/lib/BookmarkManagerDialog.ui 1216047 
  trunk/KDE/kdeedu/marble/src/lib/CMakeLists.txt 1216047 
  trunk/KDE/kdeedu/marble/src/lib/EditBookmarkDialog.h PRE-CREATION 
  trunk/KDE/kdeedu/marble/src/lib/EditBookmarkDialog.cpp PRE-CREATION 
  trunk/KDE/kdeedu/marble/src/lib/EditBookmarkDialog.ui PRE-CREATION 
  trunk/KDE/kdeedu/marble/src/lib/GeoDataTreeModel.cpp 1216047 
  trunk/KDE/kdeedu/marble/src/lib/MarbleWidgetPopupMenu.cpp 1216047 
  trunk/KDE/kdeedu/marble/src/lib/NameDialog.ui 1216047 
  trunk/KDE/kdeedu/marble/src/lib/NewBookmarkFolderDialog.h PRE-CREATION 
  trunk/KDE/kdeedu/marble/src/lib/NewBookmarkFolderDialog.cpp PRE-CREATION 
  trunk/KDE/kdeedu/marble/src/lib/NewBookmarkFolderDialog.ui PRE-CREATION 
  trunk/KDE/kdeedu/marble/src/lib/NewFolderInfoDialog.h 1216047 
  trunk/KDE/kdeedu/marble/src/lib/NewFolderInfoDialog.cpp 1216047 
  trunk/KDE/kdeedu/marble/src/marble_part.h 1216047 
  trunk/KDE/kdeedu/marble/src/marble_part.cpp 1216047 

Diff: http://svn.reviewboard.kde.org/r/6411/diff


Testing
-------


Thanks,

Dennis

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20110123/cd254f41/attachment.htm