[Marble-devel] Re: Review Request: Configurable colors for earthquake plugin

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6311/#review9584
-----------------------------------------------------------



/trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/EarthquakeConfigWidget.ui
<http://svn.reviewboard.kde.org/r/6311/#comment10568>

    Can you use a layout please to have the color buttons and labels aligned vertically, please?



/trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/EarthquakePlugin.cpp
<http://svn.reviewboard.kde.org/r/6311/#comment10567>

    No abbreviations like this, please. c => color


- Dennis


On Jan. 9, 2011, 2:52 p.m., Daniel Marth wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6311/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2011, 2:52 p.m.)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> Extends the configuration dialog for the earthquake plugin to change the color of each magnitude.
> GCI-task: http://www.google-melange.com/gci/task/show/google/gci2010/kde/t129430947316
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/EarthquakeConfigWidget.ui 1212922 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/EarthquakeItem.h 1212922 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/EarthquakeItem.cpp 1212922 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/EarthquakePlugin.h 1212922 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/EarthquakePlugin.cpp 1212922 
> 
> Diff: http://svn.reviewboard.kde.org/r/6311/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20110109/f2cf066c/attachment.htm