[Marble-devel] Re: Review Request: Writers for GeoSceneLegend, GeoSceneSettings and GeoSceneItem

[Thibaut Gridel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6305/#review9580
-----------------------------------------------------------

Ship it!


Nothing to say, all perfect!

- Thibaut


On Jan. 8, 2011, 11:43 p.m., Utku Aydin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6305/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2011, 11:43 p.m.)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> Added legend, settings and item tag writers.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneItem.h 1212989 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneItem.cpp 1212989 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneLegend.h 1212989 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneLegend.cpp 1212989 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneSection.h 1212989 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneSection.cpp 1212989 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlDocumentTagWriter.cpp 1212989 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlItemTagWriter.h PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlItemTagWriter.cpp PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlLegendTagWriter.h PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlLegendTagWriter.cpp PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlSectionTagWriter.h PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlSectionTagWriter.cpp PRE-CREATION 
>   trunk/KDE/kdeedu/marble/tests/TestGeoSceneWriter.cpp 1212989 
> 
> Diff: http://svn.reviewboard.kde.org/r/6305/diff
> 
> 
> Testing
> -------
> 
> Updated unit tests, save/parse/save/compare cycle has no problem.
> 
> 
> Thanks,
> 
> Utku
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20110109/7486a284/attachment.htm