[Marble-devel] Re: Review Request: GeoScene::writer() can write GeoSceneDocument

[Thibaut Gridel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6297/#review9576
-----------------------------------------------------------

Ship it!


it does everything advertised. and extensive testing made a full write/read/write/compare work.

- Thibaut


On Jan. 8, 2011, 3:37 p.m., Utku Aydin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6297/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2011, 3:37 p.m.)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> GeoScene::writer() can handle and write GeoSceneDocument classes now.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneDocument.h 1212874 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneDocument.cpp 1212874 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneTexture.h 1212874 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneTexture.cpp 1212874 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writer/GeoWriter.cpp 1212874 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlDocumentTagWriter.h PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlDocumentTagWriter.cpp PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlHeadTagWriter.h 1212874 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlHeadTagWriter.cpp 1212874 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlLayerTagWriter.cpp 1212874 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlMapTagWriter.cpp 1212874 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlTagWriter.h 1212874 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlTagWriter.cpp 1212874 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlTextureTagWriter.cpp 1212874 
>   trunk/KDE/kdeedu/marble/tests/TestGeoSceneWriter.cpp 1212874 
> 
> Diff: http://svn.reviewboard.kde.org/r/6297/diff
> 
> 
> Testing
> -------
> 
> Tested the changes with the unit tests.
> 
> 
> Thanks,
> 
> Utku
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20110108/033855ca/attachment.htm