[Marble-devel] Re: Review Request: About dialogs for the Navigation Plugin and the OpenDesktop Plugin

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6302/#review9574
-----------------------------------------------------------

Ship it!


Looks good. It would be nice if you could remove the orphaned line mentioned below.


trunk/KDE/kdeedu/marble/src/plugins/render/navigation/NavigationFloatItem.h
<http://svn.reviewboard.kde.org/r/6302/#comment10562>

    There's no config dialog and no use there yet, so no need to declare it.


- Torsten


On Jan. 8, 2011, 3:58 p.m., Furkan Üzümcü wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6302/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2011, 3:58 p.m.)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> Added about dialog for the Navigation Plugin and the OpenDesktop Plugin
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeedu/marble/src/plugins/render/navigation/NavigationFloatItem.h 1212905 
>   trunk/KDE/kdeedu/marble/src/plugins/render/navigation/NavigationFloatItem.cpp 1212905 
>   trunk/KDE/kdeedu/marble/src/plugins/render/opendesktop/OpenDesktopPlugin.h 1212905 
>   trunk/KDE/kdeedu/marble/src/plugins/render/opendesktop/OpenDesktopPlugin.cpp 1212905 
> 
> Diff: http://svn.reviewboard.kde.org/r/6302/diff
> 
> 
> Testing
> -------
> 
> * Tested and works.
> 
> 
> Thanks,
> 
> Furkan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20110108/55c56681/attachment.htm