[Marble-devel] Re: Review Request: GeoSceneSettings support for Map Wizard

[Thibaut Gridel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6299/#review9573
-----------------------------------------------------------



trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlDocumentTagWriter.cpp
<http://svn.reviewboard.kde.org/r/6299/#comment10561>

    cast is not needed here, document->head() returns const GeoSceneHead* already?
    That's the same for the others below i think.


- Thibaut


On Jan. 8, 2011, 9:44 a.m., Utku Aydin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6299/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2011, 9:44 a.m.)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> Added GeoSceneSettings support to map wizard.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeedu/marble/src/lib/MapWizard.cpp 1212845 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneDocument.h 1212845 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneDocument.cpp 1212845 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneProperty.h 1212845 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneProperty.cpp 1212845 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneSettings.h 1212845 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneSettings.cpp 1212845 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneTexture.h 1212845 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneTexture.cpp 1212845 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writer/GeoWriter.cpp 1212845 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlDocumentTagWriter.h PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlDocumentTagWriter.cpp PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlHeadTagWriter.h 1212845 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlHeadTagWriter.cpp 1212845 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlLayerTagWriter.cpp 1212845 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlMapTagWriter.cpp 1212845 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlTagWriter.h 1212845 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlTagWriter.cpp 1212845 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlTextureTagWriter.cpp 1212845 
>   trunk/KDE/kdeedu/marble/tests/TestGeoSceneWriter.cpp 1212845 
> 
> Diff: http://svn.reviewboard.kde.org/r/6299/diff
> 
> 
> Testing
> -------
> 
> Tested it with QDebugs, works as expected.
> 
> 
> Thanks,
> 
> Utku
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20110108/19687088/attachment.htm