[Marble-devel] Re: Review Request: GeoScene::writer() can write GeoSceneDocument

[Thibaut Gridel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6297/#review9564
-----------------------------------------------------------



trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlHeadTagWriter.cpp
<http://svn.reviewboard.kde.org/r/6297/#comment10555>

    Patch doesn't seem to introduce qDebug.
    Also please use mDebug, there is no way to disable the qDebug at runtime.



trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlMapTagWriter.cpp
<http://svn.reviewboard.kde.org/r/6297/#comment10556>

    Ditto qDebug/mDebug



trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlTagWriter.h
<http://svn.reviewboard.kde.org/r/6297/#comment10557>

    That looks mean. If you added code add your copyright, do not remove others ;)



trunk/KDE/kdeedu/marble/tests/TestGeoSceneWriter.cpp
<http://svn.reviewboard.kde.org/r/6297/#comment10558>

    The test checks more that GeoScene setters do something meaningful, and that writer.write returns true.
    
    Doing something very similar to TestGeoDataWriter, i.e. open a dgml file and parse it, write the geoscene structure back to a temp file and checking both match would check even more.
    
    This would also be more extensible as the file content wouldn't be hardcoded in the test class.


- Thibaut


On 2011-01-07 09:43:35, Utku Aydin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6297/
> -----------------------------------------------------------
> 
> (Updated 2011-01-07 09:43:35)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> GeoScene::writer() can handle and write GeoSceneDocument classes now.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneDocument.h 1212500 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneDocument.cpp 1212500 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneTexture.h 1212500 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneTexture.cpp 1212500 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writer/GeoWriter.cpp 1212500 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlDocumentTagWriter.h PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlDocumentTagWriter.cpp PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlHeadTagWriter.h 1212500 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlHeadTagWriter.cpp 1212500 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlLayerTagWriter.cpp 1212500 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlMapTagWriter.cpp 1212500 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlTagWriter.h 1212500 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlTagWriter.cpp 1212500 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlTextureTagWriter.cpp 1212500 
>   trunk/KDE/kdeedu/marble/tests/TestGeoSceneWriter.cpp 1212500 
> 
> Diff: http://svn.reviewboard.kde.org/r/6297/diff
> 
> 
> Testing
> -------
> 
> Tested the changes with the unit tests.
> 
> 
> Thanks,
> 
> Utku
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20110107/3157e9b8/attachment.htm