[Marble-devel] Re: Review Request: Configuration dialog for the Overview Map plugin

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6298/#review9562
-----------------------------------------------------------



/trunk/KDE/kdeedu/marble/src/plugins/render/overviewmap/OverviewMap.cpp
<http://svn.reviewboard.kde.org/r/6298/#comment10553>

    we prefer preincrement over postincrement where possible



/trunk/KDE/kdeedu/marble/src/plugins/render/overviewmap/OverviewMap.cpp
<http://svn.reviewboard.kde.org/r/6298/#comment10554>

    Ok, this doesn't work.
    When we were talking about the 200x100 I just meant the preview on the button (independent of the real size).
    
    Of course for the actual size you need to query that one from the size that is currently/initially used on the map. The size of the float item can be changed via the Marble API so doing it differently would clash! 


- Torsten


On 2011-01-07 15:56:09, Daniel Marth wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6298/
> -----------------------------------------------------------
> 
> (Updated 2011-01-07 15:56:09)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> Adds a configuration dialog to the overview map plugin.
> GCI-task: http://www.google-melange.com/gci/task/show/google/gci2010/kde/t129434290944?s=0
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/overviewmap/CMakeLists.txt 1212464 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/overviewmap/OverviewMap.h 1212464 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/overviewmap/OverviewMap.cpp 1212464 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/overviewmap/OverviewMapConfigWidget.ui PRE-CREATION 
> 
> Diff: http://svn.reviewboard.kde.org/r/6298/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20110107/bfd520c9/attachment.htm