[Marble-devel] Re: Review Request: Restore default settings for Marble Plugins

Torsten Rahn rahn at kde.org
Fri Jan 7 00:50:39 CET 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6295/#review9557
-----------------------------------------------------------

Ship it!


Looks good. The forwarding is a bit odd but I don't have a better solution atm.

- Torsten


On 2011-01-06 23:43:20, Daniel Marth wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6295/
> -----------------------------------------------------------
> 
> (Updated 2011-01-06 23:43:20)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> Adds an option to restore defaults in Marble plugins and implements this feature for the earthquake, graticule and positionmarker plugin.
> GCI-task: http://www.google-melange.com/gci/task/show/google/gci2010/kde/t129430982216
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/lib/RenderPlugin.h 1212415 
>   /trunk/KDE/kdeedu/marble/src/lib/RenderPlugin.cpp 1212415 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/EarthquakeConfigWidget.ui 1212415 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/EarthquakePlugin.h 1212415 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/EarthquakePlugin.cpp 1212415 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/graticule/GraticuleConfigWidget.ui 1212415 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/graticule/GraticulePlugin.h 1212415 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/graticule/GraticulePlugin.cpp 1212415 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/positionmarker/PositionMarker.h 1212415 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/positionmarker/PositionMarker.cpp 1212415 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/positionmarker/PositionMarkerConfigWidget.ui 1212415 
> 
> Diff: http://svn.reviewboard.kde.org/r/6295/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20110106/238ef110/attachment.htm 


More information about the Marble-devel mailing list