[Marble-devel] Re: Review Request: DGML Tag Writers

[Utku Aydin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6266/
-----------------------------------------------------------

(Updated 2011-01-06 11:36:00.581202)


Review request for marble.


Changes
-------

Updated GeoWriter and GeoTagWriter; they can write GeoSceneDocuments now.


Summary (updated)
-------

Created DGML tag writers, updated GeoWriter and GeoTagWriter. Also updated KML tag writers.


Diffs (updated)
-----

  trunk/KDE/kdeedu/marble/src/lib/BookmarkManager.cpp 1212262 
  trunk/KDE/kdeedu/marble/src/lib/PositionTracking.cpp 1212262 
  trunk/KDE/kdeedu/marble/src/lib/geodata/CMakeLists.txt 1212262 
  trunk/KDE/kdeedu/marble/src/lib/geodata/parser/GeoDocument.h 1212262 
  trunk/KDE/kdeedu/marble/src/lib/geodata/parser/GeoDocument.cpp 1212262 
  trunk/KDE/kdeedu/marble/src/lib/geodata/parser/GeoSceneTypes.h 1212262 
  trunk/KDE/kdeedu/marble/src/lib/geodata/parser/GeoSceneTypes.cpp 1212262 
  trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneHead.h 1212262 
  trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneHead.cpp 1212262 
  trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneLayer.h 1212262 
  trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneLayer.cpp 1212262 
  trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneMap.h 1212262 
  trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneMap.cpp 1212262 
  trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneTexture.h 1212262 
  trunk/KDE/kdeedu/marble/src/lib/geodata/scene/GeoSceneTexture.cpp 1212262 
  trunk/KDE/kdeedu/marble/src/lib/geodata/writer/GeoTagWriter.h 1212262 
  trunk/KDE/kdeedu/marble/src/lib/geodata/writer/GeoTagWriter.cpp 1212262 
  trunk/KDE/kdeedu/marble/src/lib/geodata/writer/GeoWriter.h 1212262 
  trunk/KDE/kdeedu/marble/src/lib/geodata/writer/GeoWriter.cpp 1212262 
  trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlHeadTagWriter.h PRE-CREATION 
  trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlHeadTagWriter.cpp PRE-CREATION 
  trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlLayerTagWriter.h PRE-CREATION 
  trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlLayerTagWriter.cpp PRE-CREATION 
  trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlMapTagWriter.h PRE-CREATION 
  trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlMapTagWriter.cpp PRE-CREATION 
  trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlTagWriter.h PRE-CREATION 
  trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlTagWriter.cpp PRE-CREATION 
  trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlTextureTagWriter.h PRE-CREATION 
  trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlTextureTagWriter.cpp PRE-CREATION 
  trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlDataTagWriter.h 1212262 
  trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlDataTagWriter.cpp 1212262 
  trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlDocumentTagWriter.h 1212262 
  trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlDocumentTagWriter.cpp 1212262 
  trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlExtendedDataTagWriter.h 1212262 
  trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlExtendedDataTagWriter.cpp 1212262 
  trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlFolderTagWriter.h 1212262 
  trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlFolderTagWriter.cpp 1212262 
  trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlLineStringTagWriter.h 1212262 
  trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlLineStringTagWriter.cpp 1212262 
  trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlLineStyleTagWriter.h 1212262 
  trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlLineStyleTagWriter.cpp 1212262 
  trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlLinearRingTagWriter.h 1212262 
  trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlLinearRingTagWriter.cpp 1212262 
  trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlLookAtTagWriter.h 1212262 
  trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlLookAtTagWriter.cpp 1212262 
  trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlMultiGeometryTagWriter.h 1212262 
  trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlMultiGeometryTagWriter.cpp 1212262 
  trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlPlacemarkTagWriter.h 1212262 
  trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlPlacemarkTagWriter.cpp 1212262 
  trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlPointTagWriter.h 1212262 
  trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlPointTagWriter.cpp 1212262 
  trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlStyleMapTagWriter.h 1212262 
  trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlStyleMapTagWriter.cpp 1212262 
  trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlStyleTagWriter.h 1212262 
  trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlStyleTagWriter.cpp 1212262 
  trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlTagWriter.h 1212262 
  trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlTagWriter.cpp 1212262 
  trunk/KDE/kdeedu/marble/src/lib/routing/RoutingManager.cpp 1212262 
  trunk/KDE/kdeedu/marble/tests/CMakeLists.txt 1212262 
  trunk/KDE/kdeedu/marble/tests/TestGeoDataWriter.cpp 1212262 
  trunk/KDE/kdeedu/marble/tests/TestGeoSceneWriter.cpp PRE-CREATION 

Diff: http://svn.reviewboard.kde.org/r/6266/diff


Testing (updated)
-------

* Unit test TestGeoDataWriter passes all of the tests.
* Newly created unit test "TestGeoSceneWriter" works without errors.


Thanks,

Utku

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20110106/8da05dd9/attachment.htm