[Marble-devel] Re: Review Request: Create a configuration dialog for the Earthquake plugin

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6269/#review9513
-----------------------------------------------------------



/trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/EarthquakeModel.h
<http://svn.reviewboard.kde.org/r/6269/#comment10514>

    "const int&" (same for double) isn't very Qt-ish (and a bit debatable. Typically Qt either uses plain "int" or - for the "unconst reference case" - "int*".
    At least that's my POV ... ;-)



/trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/EarthquakeModel.h
<http://svn.reviewboard.kde.org/r/6269/#comment10516>

    Wouldn't it be nicer to sort the parameters in a way so that one could possibly introduce default values (e.g. for the dates, numResults and minMagnitude)? Is this being done in a similar way for other plugins already? If so I guess that's kind of a buglet that crept into the code already ...



/trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/EarthquakePlugin.h
<http://svn.reviewboard.kde.org/r/6269/#comment10515>

    Hm, is this really about the International Dateline (which is approximalely the 180/-180-longitude half circle). Or do you mean TimeLine? Then the name of the method would be updateTimeLine() . Please adjust if this is the case since DateLine is reserved for a different meaning already.


- Torsten


On 2011-01-03 22:10:18, Daniel Marth wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6269/
> -----------------------------------------------------------
> 
> (Updated 2011-01-03 22:10:18)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> Adds a configuration dialog to the earthquake plugin. The number of results, minimum magnitude and date range can be changed.
> GCI-task: http://www.google-melange.com/gci/task/show/google/gci2010/kde/t129371479578
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/CMakeLists.txt 1210189 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/EarthquakeConfigWidget.ui PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/EarthquakeModel.h 1210189 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/EarthquakeModel.cpp 1210189 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/EarthquakePlugin.h 1210189 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/earthquake/EarthquakePlugin.cpp 1210189 
> 
> Diff: http://svn.reviewboard.kde.org/r/6269/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20110104/5843d1e3/attachment.htm