[Marble-devel] Re: Review Request: DGML Tag Writers

[Thibaut Gridel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6266/#review9496
-----------------------------------------------------------



trunk/KDE/kdeedu/marble/src/lib/geodata/writer/GeoWriter.h
<http://svn.reviewboard.kde.org/r/6266/#comment10503>

    there should be only one writeElement which works with GeoNodes.


- Thibaut


On 2011-01-03 19:39:26, Utku Aydin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6266/
> -----------------------------------------------------------
> 
> (Updated 2011-01-03 19:39:26)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> Created DGML tag writers, updated GeoWriter and GeoTagWriter (a temporary solution, not completed). Also updated KML tag writers.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/CMakeLists.txt 1211301 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/parser/GeoSceneTypes.h 1211301 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/parser/GeoSceneTypes.cpp 1211301 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writer/GeoTagWriter.h 1211301 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writer/GeoTagWriter.cpp 1211301 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writer/GeoWriter.h 1211301 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writer/GeoWriter.cpp 1211301 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlHeadTagWriter.h PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlHeadTagWriter.cpp PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlLayerTagWriter.h PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlLayerTagWriter.cpp PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlMapTagWriter.h PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlMapTagWriter.cpp PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlTextureTagWriter.h PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/dgml/DgmlTextureTagWriter.cpp PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlDataTagWriter.h 1211301 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlDataTagWriter.cpp 1211301 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlDocumentTagWriter.h 1211301 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlDocumentTagWriter.cpp 1211301 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlExtendedDataTagWriter.h 1211301 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlExtendedDataTagWriter.cpp 1211301 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlFolderTagWriter.h 1211301 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlFolderTagWriter.cpp 1211301 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlLineStringTagWriter.h 1211301 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlLineStringTagWriter.cpp 1211301 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlLineStyleTagWriter.h 1211301 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlLineStyleTagWriter.cpp 1211301 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlLinearRingTagWriter.h 1211301 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlLinearRingTagWriter.cpp 1211301 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlLookAtTagWriter.h 1211301 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlLookAtTagWriter.cpp 1211301 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlMultiGeometryTagWriter.h 1211301 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlMultiGeometryTagWriter.cpp 1211301 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlPlacemarkTagWriter.h 1211301 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlPlacemarkTagWriter.cpp 1211301 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlPointTagWriter.h 1211301 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlPointTagWriter.cpp 1211301 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlStyleMapTagWriter.h 1211301 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlStyleMapTagWriter.cpp 1211301 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlStyleTagWriter.h 1211301 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlStyleTagWriter.cpp 1211301 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlTagWriter.h 1211301 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/writers/kml/KmlTagWriter.cpp 1211301 
> 
> Diff: http://svn.reviewboard.kde.org/r/6266/diff
> 
> 
> Testing
> -------
> 
> I didn't test it yet. After reviews I will create an unit test.
> 
> 
> Thanks,
> 
> Utku
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20110103/58e96579/attachment-0001.htm