[Marble-devel] Re: Review Request: Map Creation Wizard GeoScene Refactoring

[Bernhard Beschow]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6228/#review9484
-----------------------------------------------------------



trunk/KDE/kdeedu/marble/src/lib/MapWizard.cpp
<http://svn.reviewboard.kde.org/r/6228/#comment10494>

    Why not use "const GeoSceneDocument *" here?



trunk/KDE/kdeedu/marble/src/lib/MapWizard.cpp
<http://svn.reviewboard.kde.org/r/6228/#comment10493>

    "document" needs to be deleted somewhere. You can use QSharedPointer to have it automatically deleted for you.



trunk/KDE/kdeedu/marble/src/lib/MapWizard.cpp
<http://svn.reviewboard.kde.org/r/6228/#comment10495>

    d->mapTheme should be initialized immediately after createDocument() for improved code readability: First do the variable initializations, then make use of them.



trunk/KDE/kdeedu/marble/src/lib/geodata/parser/GeoSceneTypes.h
<http://svn.reviewboard.kde.org/r/6228/#comment10496>

    Why not use Marble's standard license header for consistency reasons?



trunk/KDE/kdeedu/marble/src/lib/geodata/parser/GeoSceneTypes.cpp
<http://svn.reviewboard.kde.org/r/6228/#comment10497>

    dito


- Bernhard


On 2010-12-31 18:42:26, Utku Aydin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6228/
> -----------------------------------------------------------
> 
> (Updated 2010-12-31 18:42:26)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> Currently the Map Creation Wizard is making use of QXmlStreamWriter and feeds bare hardcoded strings into the DGML file. That's the first step of refactoring the Map Creation Wizard in a way so that it works based on GeoScene classes which has benefits in terms of extensibility, maintenance, etc.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeedu/marble/src/lib/MapWizard.h 1209913 
>   trunk/KDE/kdeedu/marble/src/lib/MapWizard.cpp 1209913 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/parser/GeoSceneTypes.h PRE-CREATION 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/parser/GeoSceneTypes.cpp PRE-CREATION 
> 
> Diff: http://svn.reviewboard.kde.org/r/6228/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Utku
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20110101/b7b1e54b/attachment.htm