[Marble-devel] Re: Review Request: GeoPainter::drawAnnotation: automatic text height

Torsten Rahn rahn at kde.org
Sat Feb 19 21:48:54 CET 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6525/#review9892
-----------------------------------------------------------

Ship it!


Looks good to me.

- Torsten


On Feb. 19, 2011, 7:43 p.m., Dennis Nienhüser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6525/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2011, 7:43 p.m.)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> Driving instructions are shown in the map using GeoPainter's drawAnnotation method. Since the length of the instructions varies but the size chosen is fixed, longer instructions are cut off. The patch extends drawAnnotation() to calculate and use the optimal text height when an invalid height is passed. The routing layer is adjusted accordingly. Additionally the rectangle rounding radius is shrinked a bit to have less whitespace (margins to the rectangle sides). I intend to backport this to 1.1 and 4.6.
> 
> 
> This addresses bug 265926.
>     https://bugs.kde.org/show_bug.cgi?id=265926
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeedu/marble/src/lib/GeoPainter.h 1220936 
>   trunk/KDE/kdeedu/marble/src/lib/GeoPainter.cpp 1220936 
>   trunk/KDE/kdeedu/marble/src/lib/routing/RoutingLayer.cpp 1220936 
> 
> Diff: http://svn.reviewboard.kde.org/r/6525/diff
> 
> 
> Testing
> -------
> 
> Various routes and different xRnd/yRnd parameters (radius for the rounded corners of the rectangle).
> 
> 
> Thanks,
> 
> Dennis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20110219/87cd8726/attachment.htm 


More information about the Marble-devel mailing list