[Marble-devel] Review Request: MarbleRunnerManager: consistent signals and blocking methods

Thibaut Gridel tgridel at free.fr
Fri Dec 30 23:57:14 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103591/
-----------------------------------------------------------

Review request for Marble.


Description
-------

    - xxFinished signals are emitted when all runners are finished
    - new blocking methods that wait for all runners to return the results
    - fixes for runners which didn't signal their end properly


Diffs
-----

  src/lib/MarbleRunnerManager.h 7ba1c6c 
  src/lib/MarbleRunnerManager.cpp 26e7d56 
  src/lib/RunnerTask.cpp fb4d1a5 
  src/plugins/runner/cache/CacheRunner.cpp 76b6c3f 
  src/plugins/runner/gpx/GpxRunner.cpp 6ff1390 
  src/plugins/runner/kml/KmlRunner.cpp 70b6014 
  src/plugins/runner/osm/OsmRunner.cpp 0967871 
  src/plugins/runner/pnt/PntRunner.cpp c1026c3 
  tests/CMakeLists.txt 8fe8be5 
  tests/MarbleRunnerManagerTest.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/103591/diff/diff


Testing
-------

simple test cases for each runner, in sync and async mode.


Thanks,

Thibaut Gridel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20111230/f6708569/attachment-0001.html>


More information about the Marble-devel mailing list