[Marble-devel] Review Request: Add missing KmlIconStyleTagWriter

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102611/#review9383
-----------------------------------------------------------


Hm, I'm afraid I implemented the same thing some days ago and already pushed it, not being aware of this review request. Sorry about that :-/

>From a quick look over the code your version seems to take care of not writing a default ffffffff color value. That might be something to add to the code in master.
The one I did takes care of writing the original hotspot values without doing any conversion, which I think is cleaner. Do you spot any other differences?


- Dennis Nienhüser


On Sept. 14, 2011, 11:27 a.m., Javier Becerra Elcinto wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102611/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2011, 11:27 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> Created missing KmlIconStyleTagWriter.cpp and KmlIconStyleTagWriter.h 
> Added a convenience function GeoDataIconStyle::iconPath() required by KmlIconStyleTagWriter.
> When a placemark is created with a QPixmap instead of a filename, the icon is ignored when writing to file (KML does not seem to support icons embedded in kml files, it only allows for hrefs to be used to define them, maybe there is a way to include the binary image somewhere in the document and reference it from the href in the Icon tag?).
> 
> 
> Diffs
> -----
> 
>   src/lib/geodata/data/GeoDataIconStyle.h 87ec5e1 
>   src/lib/geodata/data/GeoDataIconStyle.cpp 15a2597 
>   src/lib/geodata/writers/kml/KmlIconStyleTagWriter.h PRE-CREATION 
>   src/lib/geodata/writers/kml/KmlIconStyleTagWriter.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102611/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Javier Becerra Elcinto
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20111230/022c86b0/attachment.html>