[Marble-devel] Review Request: GCI task: Favorite weather stations in Marble

[Valery Kharitonov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103444/
-----------------------------------------------------------

(Updated Dec. 30, 2011, 1:34 p.m.)


Review request for Marble.


Changes
-------

Updated diff and description. It now depends on this patch: https://git.reviewboard.kde.org/r/103582/


Description (updated)
-------

http://www.google-melange.com/gci/task/view/google/gci2011/7154206

Depends on https://git.reviewboard.kde.org/r/103582/


Diffs (updated)
-----

  src/plugins/render/weather/AbstractWeatherService.h bf85e7b 
  src/plugins/render/weather/AbstractWeatherService.cpp 7fbefb5 
  src/plugins/render/weather/BBCWeatherService.h 918228f 
  src/plugins/render/weather/BBCWeatherService.cpp 1dbf79d 
  src/plugins/render/weather/FakeWeatherService.cpp e765b67 
  src/plugins/render/weather/WeatherConfigWidget.ui 598ecf6 
  src/plugins/render/weather/WeatherItem.h 533545a 
  src/plugins/render/weather/WeatherItem.cpp 0beb7d4 
  src/plugins/render/weather/WeatherModel.h 720d866 
  src/plugins/render/weather/WeatherModel.cpp 51dfac1 
  src/plugins/render/weather/WeatherPlugin.h b818f65 
  src/plugins/render/weather/WeatherPlugin.cpp 67f0deb 

Diff: http://git.reviewboard.kde.org/r/103444/diff/diff


Testing
-------


Screenshots
-----------

Settings dialog with new options
  http://git.reviewboard.kde.org/r/103444/s/374/
Item with "favorite" icon
  http://git.reviewboard.kde.org/r/103444/s/375/


Thanks,

Valery Kharitonov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20111230/f1af8a8a/attachment.html>