[Marble-devel] Review Request: gpx waypoint/route improvements

[Anders Lund]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103407/
-----------------------------------------------------------

Review request for Marble.


Description
-------

More gpx improvements:
* Use desc tag to add waypoint and route descriptions
* Use ele tag to set waypoint altitude
* Set a default Role for routepoints and waypoints, and use the gpx type tag to change that if present
* Support custom role by displaying a custom role string in placemark information dialog if present

NOTE: This patch creates handlers for the ele gpx tag, that is also in another review (by Niko Sams).  Merging should be straight forward.


Diffs
-----

  src/lib/PlacemarkInfoDialog.cpp e9889ee 
  src/plugins/runner/gpx/CMakeLists.txt e0d3e07 
  src/plugins/runner/gpx/handlers/GPXElementDictionary.h c5c35f7 
  src/plugins/runner/gpx/handlers/GPXElementDictionary.cpp 8355a3b 
  src/plugins/runner/gpx/handlers/GPXdescTagHandler.h PRE-CREATION 
  src/plugins/runner/gpx/handlers/GPXdescTagHandler.cpp PRE-CREATION 
  src/plugins/runner/gpx/handlers/GPXeleTagHandler.h PRE-CREATION 
  src/plugins/runner/gpx/handlers/GPXeleTagHandler.cpp PRE-CREATION 
  src/plugins/runner/gpx/handlers/GPXnameTagHandler.cpp 400c9c8 
  src/plugins/runner/gpx/handlers/GPXrteTagHandler.cpp 022744d 
  src/plugins/runner/gpx/handlers/GPXrteptTagHandler.h c5b420a 
  src/plugins/runner/gpx/handlers/GPXrteptTagHandler.cpp 994fcbf 
  src/plugins/runner/gpx/handlers/GPXtypeTagHandler.h PRE-CREATION 
  src/plugins/runner/gpx/handlers/GPXtypeTagHandler.cpp PRE-CREATION 
  src/plugins/runner/gpx/handlers/GPXwptTagHandler.cpp b7efbe4 
  your-patch.patch 96675b8 

Diff: http://git.reviewboard.kde.org/r/103407/diff/diff


Testing
-------

I've been using this without problems, and verified that altitude, descriptions and roles display correctly


Thanks,

Anders Lund

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20111213/041a81c9/attachment.html>