[Marble-devel] Review Request: add gpx route support

[Thibaut Gridel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103389/#review8929
-----------------------------------------------------------

Ship it!


A nice looking patch, well done!
Haven't tested, code looks OK though so please commit.


- Thibaut Gridel


On Dec. 12, 2011, 5:01 p.m., Anders Lund wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103389/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2011, 5:01 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> Add support for simple display of routes from gpx, and style the display of waypoints from gpx with a flag icon.
> 
> 
> Diffs
> -----
> 
>   data/bitmaps/flag.png PRE-CREATION 
>   src/plugins/runner/gpx/CMakeLists.txt dae7719 
>   src/plugins/runner/gpx/handlers/GPXElementDictionary.h 37152bd 
>   src/plugins/runner/gpx/handlers/GPXElementDictionary.cpp 471ad64 
>   src/plugins/runner/gpx/handlers/GPXgpxTagHandler.cpp d3e64ef 
>   src/plugins/runner/gpx/handlers/GPXnameTagHandler.cpp ad45159 
>   src/plugins/runner/gpx/handlers/GPXrteTagHandler.h PRE-CREATION 
>   src/plugins/runner/gpx/handlers/GPXrteTagHandler.cpp PRE-CREATION 
>   src/plugins/runner/gpx/handlers/GPXrteptTagHandler.h PRE-CREATION 
>   src/plugins/runner/gpx/handlers/GPXrteptTagHandler.cpp PRE-CREATION 
>   src/plugins/runner/gpx/handlers/GPXwptTagHandler.cpp b74a256 
> 
> Diff: http://git.reviewboard.kde.org/r/103389/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> marble with a route and some waypoints
>   http://git.reviewboard.kde.org/r/103389/s/362/
> 
> 
> Thanks,
> 
> Anders Lund
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20111213/0a2d979a/attachment.html>