[Marble-devel] Review Request: GeoData KML and GPX Parser: parse ExtendedData in gx:Track

[Niko Sams]

*ping*
could someone please review my changes?

thanks,
Niko

On Sat, Nov 26, 2011 at 11:43, Niko Sams <niko.sams at gmail.com> wrote:

>    This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103191/
>   Review request for Marble.
> By Niko Sams.
>
> *Updated Nov. 26, 2011, 10:43 a.m.*
> Changes
>
> Updated patch with changed storage of track data.
> The example with partially missing time information can be represented now correctly.
>
> I tried using QMultiMap but was not successful mainly because values() returns values
> with equal key in reverse order.
>
>   Description
>
> gx:Track can contain ExtendedData used for embedding eg. heartrate data to a track:http://code.google.com/intl/de-DE/apis/kml/documentation/kmlreference.html#gxtrack
>
> This patch implements:
> - the data structure in GeoDataTrack
> - the kml parser for this structure (supporting example files in kml specs)
> - the gpx parser for this structure (supporting files created by garmin devices)
>
> Gpx parser also now handles elevation data.
>
> Gpx parser now creates a GeoDataTrack object (instead of GeoDataLineString)
> (I'm not sure if this change could cause problems)
>
>   Testing
>
> Unittests included in patch.
>
>   Diffs (updated)
>
>    - CMakeLists.txt (3857121)
>    - src/lib/.TracksModel.cpp.kate-swp (PRE-CREATION)
>    - src/lib/geodata/data/GeoDataExtendedData.h (f095cdb)
>    - src/lib/geodata/data/GeoDataExtendedData.cpp (4011240)
>    - src/lib/geodata/data/GeoDataExtendedData_p.h (361e894)
>    - src/lib/geodata/data/GeoDataSimpleArrayData.h (PRE-CREATION)
>    - src/lib/geodata/data/GeoDataSimpleArrayData.cpp (PRE-CREATION)
>    - src/lib/geodata/data/GeoDataTrack.h (2f0e0c3)
>    - src/lib/geodata/data/GeoDataTrack.cpp (c8b5ccf)
>    - src/lib/geodata/data/Serializable.h (cfa4b74)
>    - src/lib/geodata/handlers/kml/KmlCoordinatesTagHandler.cpp (dce7679)
>    - src/lib/geodata/handlers/kml/KmlElementDictionary.h (624465a)
>    - src/lib/geodata/handlers/kml/KmlElementDictionary.cpp (07f33fd)
>    - src/lib/geodata/handlers/kml/KmlExtendedDataTagHandler.cpp (669fb5e)
>    - src/lib/geodata/handlers/kml/KmlSchemaDataTagHandler.h (PRE-CREATION)
>    - src/lib/geodata/handlers/kml/KmlSchemaDataTagHandler.cpp
>    (PRE-CREATION)
>    - src/lib/geodata/handlers/kml/KmlSimpleArrayDataTagHandler.h
>    (PRE-CREATION)
>    - src/lib/geodata/handlers/kml/KmlSimpleArrayDataTagHandler.cpp
>    (PRE-CREATION)
>    - src/lib/geodata/handlers/kml/KmlValueTagHandler.cpp (a2e5441)
>    - src/lib/geodata/parser/GeoDataTypes.h (fee81bd)
>    - src/lib/geodata/parser/GeoDataTypes.cpp (4443896)
>    - src/plugins/runner/gpx/CMakeLists.txt (dae7719)
>    - src/plugins/runner/gpx/GpxParser.cpp (61a749f)
>    - src/plugins/runner/gpx/handlers/GPXElementDictionary.h (37152bd)
>    - src/plugins/runner/gpx/handlers/GPXElementDictionary.cpp (471ad64)
>    - src/plugins/runner/gpx/handlers/GPXTrackPointExtensionTagHandler.h
>    (PRE-CREATION)
>    - src/plugins/runner/gpx/handlers/GPXTrackPointExtensionTagHandler.cpp
>    (PRE-CREATION)
>    - src/plugins/runner/gpx/handlers/GPXeleTagHandler.h (PRE-CREATION)
>    - src/plugins/runner/gpx/handlers/GPXeleTagHandler.cpp (PRE-CREATION)
>    - src/plugins/runner/gpx/handlers/GPXextensionsTagHandler.h
>    (PRE-CREATION)
>    - src/plugins/runner/gpx/handlers/GPXextensionsTagHandler.cpp
>    (PRE-CREATION)
>    - src/plugins/runner/gpx/handlers/GPXhrTagHandler.h (PRE-CREATION)
>    - src/plugins/runner/gpx/handlers/GPXhrTagHandler.cpp (PRE-CREATION)
>    - src/plugins/runner/gpx/handlers/GPXtimeTagHandler.h (PRE-CREATION)
>    - src/plugins/runner/gpx/handlers/GPXtimeTagHandler.cpp (PRE-CREATION)
>    - src/plugins/runner/gpx/handlers/GPXtrkptTagHandler.cpp (455e8e1)
>    - src/plugins/runner/gpx/handlers/GPXtrksegTagHandler.cpp (9b1a24e)
>    - src/plugins/runner/gpx/tests/TestTrack.cpp (PRE-CREATION)
>    - tests/TestGeoDataTrack.cpp (c9f347d)
>
> View Diff <http://git.reviewboard.kde.org/r/103191/diff/>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20111208/8e7a9fa4/attachment.html>